feat: add option to truncate GitHub annotations - #157
Open
Haadiyah-Zafar wants to merge 2 commits into
Open
Conversation
Haadiyah-Zafar
changed the title
Collaborator
|
Thanks for the PR @Haadiyah-Zafar! Wanna fix the failing tests? |
edgarrmondragon
requested changes
Aug 30, 2026
edgarrmondragon
left a comment
edgarrmondragon
left a comment
Collaborator
There was a problem hiding this comment.
The plugin is already enabled by default in tests
Comment on lines
+440
to
+444
| result = pytester.runpytest_subprocess( | ||
| "-p", | ||
| "pytest_github_actions_annotate_failures.plugin", | ||
| "--github-annotation-max-length=-1", | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| result = pytester.runpytest_subprocess( | |
| "-p", | |
| "pytest_github_actions_annotate_failures.plugin", | |
| "--github-annotation-max-length=-1", | |
| ) | |
| result = pytester.runpytest_subprocess("--github-annotation-max-length=-1") |
Comment on lines
+422
to
+426
| result = pytester.runpytest_subprocess( | ||
| "-p", | ||
| "pytest_github_actions_annotate_failures.plugin", | ||
| "--github-annotation-max-length=80", | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| result = pytester.runpytest_subprocess( | |
| "-p", | |
| "pytest_github_actions_annotate_failures.plugin", | |
| "--github-annotation-max-length=80", | |
| ) | |
| result = pytester.runpytest_subprocess("--github-annotation-max-length=80") |
| ) | ||
|
|
||
| PYTEST_VERSION = version.parse(pytest.__version__) | ||
| REPO_ROOT = Path(__file__).parent |
Collaborator
There was a problem hiding this comment.
Why do we need this for the new tests? Can we get rid of it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--github-annotation-max-lengthto optionally truncate long GitHub Actions annotation messages.The default remains
0, which preserves the current behavior and disables truncation.This helps keep the GitHub Actions annotations view readable when failures contain very long assertion messages or tracebacks.
Tests added for: